Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add more OpenGL Attributes #54751

Merged
merged 1 commit into from
Nov 8, 2021
Merged

[3.x] Add more OpenGL Attributes #54751

merged 1 commit into from
Nov 8, 2021

Conversation

NHodgesVFX
Copy link
Contributor

Co-Authored-By: Johann Meyer [email protected]
Co-Authored-By: Clay John [email protected]

Adds GL_VertexID to Spatial and CanvasItem shaders and adds GL_InstanceID to canvas item.

Thanks to Johann Meyer and Clay John for making adding this easy
#19473 (comment)

@NHodgesVFX NHodgesVFX requested a review from a team as a code owner November 8, 2021 05:54
Co-Authored-By: Johann Meyer <[email protected]>
Co-Authored-By: Clay John <[email protected]>
@akien-mga
Copy link
Member

Does this address godotengine/godot-proposals#3465?

@NHodgesVFX
Copy link
Contributor Author

No, this exposes two built in attributes that OpenGL provides. The proposal above is about defining your own attributes. I will be creating a 4.x version of this PR tonight.

@akien-mga akien-mga merged commit cfff7a9 into godotengine:3.x Nov 8, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants